Port back feature from nobleo-noetic-devel where we also report the message that made stuff go bad #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll review later. But I'd like PR 324 to be merged before we open a new PR with these changes. |
|
Sure thing, but our nobleo:ros2 branch is already different from our PR variant, so merging this won't hurt that PR? |
Timple
reviewed
Feb 1, 2024
|
Would it be possible to base of the |
|
I can't find the button :/ |
…essage that made stuff go bad
MCFurry
force-pushed
the
feature/report_non_okay_details
branch
from
45ae82c
to
28ddac0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like we did in ROS1, we also want to report the message that made the diagnostics go bad, to toplevel state.
This is also since some of our Harvey algorithms depend on this single conclusion